Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid @method annotation in DefaultTemplate #342

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Invalid @method annotation in DefaultTemplate #342

wants to merge 3 commits into from

Conversation

mildabre
Copy link
Contributor

No BC break

I propose remove @method annotation of two non-existing methods you can't even call magically. IDE makes false suggestion in presenter when used type annotation DefaultTemplate for magic property $template:

/**
 * @property DefaultTemplate $template
 */
final class MyPresenter extends BasePresenter
{
    public function actionDefault(): void
    {
        $isLinkCurrent = $this->template->isLinkCurrent(':Common:Sign:login');
    }
}

This code makes error:

Error
Call to undefined method Nette\Bridges\ApplicationLatte\DefaultTemplate::isLinkCurrent()

It looks like the annotations have no function at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mildabre